Repository navigation
Don't install R packages in the Jenkins image - #602
Merged
Merged
Conversation
The shiny install added to docker/jenkins/Dockerfile.ubuntu-20.04 broke the image build. On focal the install falls back to compiling from source -- the PPM binary repo only serves binaries when the client sends a matching HTTPUserAgent, which a bare `Rscript -e install.packages(...)` does not -- and building `shiny -> bslib -> sass -> fs` then needs libuv, which the image doesn't have. Rather than add libuv and a user-agent dance, drop it: Jenkins runs `mocha test test/integration` and never `npm run test:r`, so that image was being provisioned for a tier it does not execute. The real-R tier already runs on GitHub Actions, which is where it belongs, and Jenkins is expected to be retired after the current round of refactors. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the master Jenkins build, broken by #599.
#599 added
install.packages("shiny")todocker/jenkins/Dockerfile.ubuntu-20.04so the real-R tier wouldn't skipitself there. On focal that install compiles from source — the PPM binary repo
only serves binaries when the client sends a matching
HTTPUserAgent, which abare
Rscript -e install.packages(...)doesn't — and buildingshiny -> bslib -> sass -> fsthen needs libuv, which the image doesn't have.The fix isn't to add libuv and a user-agent dance, because the change was
unnecessary in the first place:
Jenkinsfile:108runsmocha test test/integrationand nevernpm run test:r. That image was beingprovisioned for a tier it does not execute. The real-R tier runs on GitHub
Actions, which has R via
r-lib/actions/setup-rand is green.Also records in
memory-bank/testingGuide.mdthat the R tier is GHA-only andwhy, so it doesn't get added back — plus a note that
Jenkinsfile.internal:138still runsmocha testonly, so the internal buildskips the integration tier. Left alone deliberately, given Jenkins is expected
to be retired after this round of refactors.
Verified:
npm test310 passing,npm run test:r8 passing, unaffected — thisonly touches the Docker image and a doc.
🤖 Generated with Claude Code